FaSTTUBe/GST-Tensordecoder-ov_ep
61
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

appsink: Only notify drop property and not in/out

Browse Source 
This mirrors the behaviour of audiorate / videorate better and observing in/out
buffers can be achieved more cheaply via other means.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8866>
This commit is contained in:
Sebastian Dröge 2025-04-18 12:26:30 +03:00
parent 953bc7cd0e
commit 9920897c4a
2 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json
View File

@ -464,7 +464,7 @@
"writable": false "writable": false
}, },
"silent": { "silent": {
"blurb": "Don't emit notify for input, output and dropped buffers", "blurb": "Don't emit notify for dropped buffers",
"conditionally-available": false, "conditionally-available": false,
"construct": false, "construct": false,
"construct-only": false, "construct-only": false,

17
subprojects/gst-plugins-base/gst-libs/gst/app/gstappsink.c
View File

@ -445,7 +445,7 @@ gst_app_sink_class_init (GstAppSinkClass * klass)
*/ */
g_object_class_install_property (gobject_class, PROP_SILENT, g_object_class_install_property (gobject_class, PROP_SILENT,
g_param_spec_boolean ("silent", "silent", g_param_spec_boolean ("silent", "silent",
"Don't emit notify for input, output and dropped buffers", "Don't emit notify for dropped buffers",
DEFAULT_SILENT, DEFAULT_SILENT,
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS |
GST_PARAM_MUTABLE_PLAYING)); GST_PARAM_MUTABLE_PLAYING));
@ -1025,8 +1025,6 @@ gst_app_sink_stop (GstBaseSink * psink)
g_mutex_unlock (&priv->mutex); g_mutex_unlock (&priv->mutex);
if (!priv->silent) { if (!priv->silent) {
g_object_notify (G_OBJECT (appsink), "in");
g_object_notify (G_OBJECT (appsink), "out");
g_object_notify (G_OBJECT (appsink), "dropped"); g_object_notify (G_OBJECT (appsink), "dropped");
} }
@ -1132,8 +1130,6 @@ gst_app_sink_event (GstBaseSink * sink, GstEvent * event)
g_mutex_unlock (&priv->mutex); g_mutex_unlock (&priv->mutex);
if (!priv->silent) { if (!priv->silent) {
g_object_notify (G_OBJECT (appsink), "in");
g_object_notify (G_OBJECT (appsink), "out");
g_object_notify (G_OBJECT (appsink), "dropped"); g_object_notify (G_OBJECT (appsink), "dropped");
} }
break; break;
@ -1386,10 +1382,6 @@ restart:
callbacks = callbacks_ref (priv->callbacks); callbacks = callbacks_ref (priv->callbacks);
g_mutex_unlock (&priv->mutex); g_mutex_unlock (&priv->mutex);
if (!priv->silent) {
g_object_notify (G_OBJECT (appsink), "in");
}
if (callbacks && callbacks->callbacks.new_sample) { if (callbacks && callbacks->callbacks.new_sample) {
ret = callbacks->callbacks.new_sample (appsink, callbacks->user_data); ret = callbacks->callbacks.new_sample (appsink, callbacks->user_data);
} else { } else {
@ -2445,12 +2437,10 @@ gst_app_sink_try_pull_object (GstAppSink * appsink, GstClockTime timeout)
obj = dequeue_object (appsink); obj = dequeue_object (appsink);
gboolean notify_out = FALSE;
/* convert buffer and buffer list to sample */ /* convert buffer and buffer list to sample */
if (GST_IS_BUFFER (obj)) { if (GST_IS_BUFFER (obj)) {
GST_DEBUG_OBJECT (appsink, "we have a buffer %p", obj); GST_DEBUG_OBJECT (appsink, "we have a buffer %p", obj);
priv->out += 1; priv->out += 1;
notify_out = !priv->silent;
priv->sample = gst_sample_make_writable (priv->sample); priv->sample = gst_sample_make_writable (priv->sample);
gst_sample_set_buffer_list (priv->sample, NULL); gst_sample_set_buffer_list (priv->sample, NULL);
gst_sample_set_buffer (priv->sample, GST_BUFFER_CAST (obj)); gst_sample_set_buffer (priv->sample, GST_BUFFER_CAST (obj));
@ -2459,7 +2449,6 @@ gst_app_sink_try_pull_object (GstAppSink * appsink, GstClockTime timeout)
} else if (GST_IS_BUFFER_LIST (obj)) { } else if (GST_IS_BUFFER_LIST (obj)) {
GST_DEBUG_OBJECT (appsink, "we have a list %p", obj); GST_DEBUG_OBJECT (appsink, "we have a list %p", obj);
priv->out += gst_buffer_list_length (GST_BUFFER_LIST_CAST (obj)); priv->out += gst_buffer_list_length (GST_BUFFER_LIST_CAST (obj));
notify_out = !priv->silent;
priv->sample = gst_sample_make_writable (priv->sample); priv->sample = gst_sample_make_writable (priv->sample);
gst_sample_set_buffer (priv->sample, NULL); gst_sample_set_buffer (priv->sample, NULL);
gst_sample_set_buffer_list (priv->sample, GST_BUFFER_LIST_CAST (obj)); gst_sample_set_buffer_list (priv->sample, GST_BUFFER_LIST_CAST (obj));
@ -2474,10 +2463,6 @@ gst_app_sink_try_pull_object (GstAppSink * appsink, GstClockTime timeout)
g_mutex_unlock (&priv->mutex); g_mutex_unlock (&priv->mutex);
if (notify_out) {
g_object_notify (G_OBJECT (appsink), "out");
}
return ret; return ret;
/* special conditions */ /* special conditions */