From 985ed4847f34d1eb3b954725c5e53c870a81c5db Mon Sep 17 00:00:00 2001 From: Luis de Bethencourt Date: Mon, 30 Mar 2015 10:50:45 +0100 Subject: [PATCH] playbin: avoid possible deference of null pointer For safety, check the pointer playbin->curr_group is valid before reading parameters of the structure. CID #1291624 --- gst/playback/gstplaybin2.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c index 9f395f7d91..bf227662ce 100644 --- a/gst/playback/gstplaybin2.c +++ b/gst/playback/gstplaybin2.c @@ -5734,11 +5734,13 @@ failure: GstSourceGroup *curr_group; curr_group = playbin->curr_group; - if (curr_group && curr_group->active && curr_group->valid) { - /* unlink our pads with the sink */ - deactivate_group (playbin, curr_group); + if (curr_group) { + if (curr_group->active && curr_group->valid) { + /* unlink our pads with the sink */ + deactivate_group (playbin, curr_group); + } + curr_group->valid = FALSE; } - curr_group->valid = FALSE; /* Swap current and next group back */ playbin->curr_group = playbin->next_group;