FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

glmixer: fix caps leak in gst_gl_mixer_pad_sink_getcaps()

Browse Source 
Caps refcounting was all wrong in this function. Rewrote it and add some
comments to make it clearer.

Fix caps leaks with the
validate.file.glvideomixer.simple.play_15s.synchronized scenario.

https://bugzilla.gnome.org/show_bug.cgi?id=747915

Signed-off-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
This commit is contained in:
Guillaume Desmottes 2015-04-15 15:22:37 +02:00 committed by Vincent Penquerc'h
parent f5f632a503
commit 9827138061
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ext/gl/gstglmixer.c
View File

@ -213,27 +213,27 @@ gst_gl_mixer_pad_sink_getcaps (GstPad * pad, GstGLMixer * mix, GstCaps * filter)
GstCaps *template_caps; GstCaps *template_caps;
GstCaps *filtered_caps; GstCaps *filtered_caps;
GstCaps *returned_caps; GstCaps *returned_caps;
gboolean had_current_caps = TRUE;
template_caps = gst_pad_get_pad_template_caps (pad); template_caps = gst_pad_get_pad_template_caps (pad);
sinkcaps = gst_pad_get_current_caps (pad); sinkcaps = gst_pad_get_current_caps (pad);
if (sinkcaps == NULL) { if (sinkcaps == NULL) {
had_current_caps = FALSE; sinkcaps = gst_caps_ref (template_caps);
sinkcaps = template_caps;
} else { } else {
sinkcaps = gst_caps_merge (sinkcaps, template_caps); sinkcaps = gst_caps_merge (sinkcaps, gst_caps_ref (template_caps));
} }
filtered_caps = sinkcaps; if (filter) {
if (filter)
filtered_caps = gst_caps_intersect (sinkcaps, filter); filtered_caps = gst_caps_intersect (sinkcaps, filter);
gst_caps_unref (sinkcaps);
} else {
filtered_caps = sinkcaps; /* pass ownership */
}
returned_caps = gst_caps_intersect (filtered_caps, template_caps); returned_caps = gst_caps_intersect (filtered_caps, template_caps);
if (filter) gst_caps_unref (template_caps);
gst_caps_unref (filtered_caps); gst_caps_unref (filtered_caps);
if (had_current_caps)
gst_caps_unref (template_caps);
GST_DEBUG_OBJECT (pad, "returning %" GST_PTR_FORMAT, returned_caps); GST_DEBUG_OBJECT (pad, "returning %" GST_PTR_FORMAT, returned_caps);