From 96faac28915055504aeaca16f8a5528b7c933c28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Tue, 21 Aug 2012 22:51:38 +0100 Subject: [PATCH] pango: fix bad unref and crashes with multiple text overlays gst_element_class_get_pad_template() does not return a ref, so we mustn't unref the template returned. Fixes crashes when switching back and forth between different types of subtitle streams. --- ext/pango/gstbasetextoverlay.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ext/pango/gstbasetextoverlay.c b/ext/pango/gstbasetextoverlay.c index 072d680be8..1bc8ce7a51 100644 --- a/ext/pango/gstbasetextoverlay.c +++ b/ext/pango/gstbasetextoverlay.c @@ -629,7 +629,6 @@ gst_base_text_overlay_init (GstBaseTextOverlay * overlay, if (template) { /* text sink */ overlay->text_sinkpad = gst_pad_new_from_template (template, "text_sink"); - gst_object_unref (template); gst_pad_set_event_function (overlay->text_sinkpad, GST_DEBUG_FUNCPTR (gst_base_text_overlay_text_event));