FaSTTUBe/GST-Tensordecoder-ov_ep
61
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

mpegts: Fix PCR Discontinuity handling for HLS

Browse Source 
We can only reliably use the adaptation field discontinuity flag if our input is
properly timestamped on a regular basis (ex: UDP, DVB, RTP, etc...).

For HLS and other systems which don't provide that information, we should not
reset the base observations. Otherwise we would potentially end up picking a
reference time from a long time ago.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8480>
This commit is contained in:
Edward Hervey 2025-02-14 14:10:25 +01:00 committed by GStreamer Marge Bot
parent 54a0ad7161
commit 96e660e0d9
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
subprojects/gst-plugins-bad/gst/mpegtsdemux/mpegtspacketizer.c
View File

@ -414,24 +414,20 @@ mpegts_packetizer_parse_adaptation_field_control (MpegTSPacketizer2 *
if (packetizer->calculate_skew
&& GST_CLOCK_TIME_IS_VALID (packetizer->last_in_time)) {
pcrtable = get_pcr_table (packetizer, packet->pid);
/* There is a signalled discontinuity. Reset observations */
if (afcflags & MPEGTS_AFC_DISCONTINUITY_FLAG) {
/* There is a signalled discontinuity and we deal with regularly timed
* input. Reset observations */
if (afcflags & MPEGTS_AFC_DISCONTINUITY_FLAG &&
(GST_CLOCK_TIME_IS_VALID (packetizer->last_dts) ||
GST_CLOCK_TIME_IS_VALID (packetizer->last_pts))) {
MpegTSPCR *fallback = get_pcr_table (packetizer, 0x1fff);
GST_DEBUG ("pcr 0x%04x Discontinuity signalled, resetting observations",
packet->pid);
pcrtable->base_time = GST_CLOCK_TIME_NONE;
pcrtable->base_pcrtime = GST_CLOCK_TIME_NONE;
fallback->base_time = GST_CLOCK_TIME_NONE;
}
calculate_skew (packetizer, pcrtable, packet->pcr,
packetizer->last_in_time);
if (afcflags & MPEGTS_AFC_DISCONTINUITY_FLAG) {
MpegTSPCR *ignore_pcr =
packetizer->observations[packetizer->pcrtablelut[0x1fff]];
if (ignore_pcr) {
GST_DEBUG ("Resetting fallback PCR table due to discontinuity");
/* If there is a discontinuity, we need to reset the fallback PCR in case of */
ignore_pcr->base_time = GST_CLOCK_TIME_NONE;
}
}
}
if (packetizer->calculate_offset) {
if (!pcrtable)