From 966c39b92e1c4456b9512c0e19bdd439e7fd681b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Sun, 26 May 2024 13:00:02 +0300 Subject: [PATCH] rtspsrc: Don't try the SETUP workaround for broken servers with absolute control URIs Previously only control URIs that started with "rtsp://" were ignored but it makes more sense to ignore all absolute URIs. gst_uri_is_valid() conveniently checks for exactly that. See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3563 Part-of: --- subprojects/gst-plugins-good/gst/rtsp/gstrtspsrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-good/gst/rtsp/gstrtspsrc.c b/subprojects/gst-plugins-good/gst/rtsp/gstrtspsrc.c index fed9ef1420..154b3b40e3 100644 --- a/subprojects/gst-plugins-good/gst/rtsp/gstrtspsrc.c +++ b/subprojects/gst-plugins-good/gst/rtsp/gstrtspsrc.c @@ -7866,7 +7866,7 @@ gst_rtspsrc_setup_streams_start (GstRTSPSrc * src, gboolean async) * https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1447 */ if (!tried_non_compliant_url && stream->control_url - && !g_str_has_prefix (stream->control_url, "rtsp://")) { + && !gst_uri_is_valid (stream->control_url)) { const gchar *base; gst_rtsp_message_unset (&request);