From 956be9a0182560459a49aab23870adb4395e11d1 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Wed, 9 Apr 2014 17:37:41 +0100 Subject: [PATCH] schrodec: remove unnecessary check The tag was dereferenced earier. From the libschroedinger code, it's not obvious to see whether tag and frame would be NULL at the same time. I think is likely that both will be non NULL here, but that's not certain. Additional tests may be needed to avoid dereferencing tag and/or frame, but what to do if only one is NULL isn't obvious, as the _get_tag function does transfer ownership so isn't undoable. Coverity 1139850 --- ext/schroedinger/gstschrodec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ext/schroedinger/gstschrodec.c b/ext/schroedinger/gstschrodec.c index 72f293dd28..00f442eb52 100644 --- a/ext/schroedinger/gstschrodec.c +++ b/ext/schroedinger/gstschrodec.c @@ -498,8 +498,7 @@ gst_schro_dec_process (GstSchroDec * schro_dec, gboolean eos) schro_frame_unref (schro_frame); } - if (tag) - schro_tag_free (tag); + schro_tag_free (tag); if (!eos) { go = FALSE; }