From 936f89a0d5d23698d4c22c1314a26b80827d641b Mon Sep 17 00:00:00 2001 From: Naveen Cherukuri Date: Tue, 4 Dec 2018 16:15:22 +0530 Subject: [PATCH] kmssink: Avoiding get_property to take ownership of object members Double free will happen if application frees string retuned by _get_property --- sys/kms/gstkmssink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kms/gstkmssink.c b/sys/kms/gstkmssink.c index 70308af986..5a912e2a77 100644 --- a/sys/kms/gstkmssink.c +++ b/sys/kms/gstkmssink.c @@ -1785,10 +1785,10 @@ gst_kms_sink_get_property (GObject * object, guint prop_id, switch (prop_id) { case PROP_DRIVER_NAME: - g_value_take_string (value, sink->devname); + g_value_set_string (value, sink->devname); break; case PROP_BUS_ID: - g_value_take_string (value, sink->bus_id); + g_value_set_string (value, sink->bus_id); break; case PROP_CONNECTOR_ID: g_value_set_int (value, sink->conn_id);