From 9365073d50064c90e4ea6def051e49bb7576175b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?=
 <vjaquez@igalia.com>
Date: Wed, 31 Mar 2021 11:04:17 +0200
Subject: [PATCH] va: postproc: Set usage hint generic if DMABuf.

iHD driver sets a tiled DRM modifier if surface's usage hint is set to
VPP_WRITE. This result in a garbled rendering when using glimagesink.

This patch changes the usage hint to generic if the caps feature is
DMABuf. Either way only iHD driver, so far, uses the usage hint flag.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2127>
---
 sys/va/gstvavpp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sys/va/gstvavpp.c b/sys/va/gstvavpp.c
index 6ba0b5c256..9944ef0fac 100644
--- a/sys/va/gstvavpp.c
+++ b/sys/va/gstvavpp.c
@@ -691,6 +691,9 @@ gst_va_vpp_decide_allocation (GstBaseTransform * trans, GstQuery * query)
   }
 
   if (!allocator) {
+    /* XXX(victor): VPP_WRITE uses a tiled drm modifier by iHD */
+    if (gst_caps_is_dmabuf (outcaps) && GST_VIDEO_INFO_IS_RGB (&vinfo))
+      usage_hint = VA_SURFACE_ATTRIB_USAGE_HINT_GENERIC;
     if (!(allocator = _create_allocator (self, outcaps, usage_hint)))
       return FALSE;
   }