From 91f2f1874c5aab3bb54783d6060731d6f86c99b3 Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Thu, 2 Jul 2015 10:47:45 -0400 Subject: [PATCH] basetextoverlay: Fix bug with unused upstream_has_meta The intention was to skip the allocation query if upstream has decided to use the overlay meta feature in the caps. We can safely assume that upstream have done that query already before making this decision. This is an optimization since doing allocation queries is relatively expensive. CID #1308943 --- ext/pango/gstbasetextoverlay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/pango/gstbasetextoverlay.c b/ext/pango/gstbasetextoverlay.c index 301db50d5e..b1b3b9373e 100644 --- a/ext/pango/gstbasetextoverlay.c +++ b/ext/pango/gstbasetextoverlay.c @@ -718,7 +718,7 @@ gst_base_text_overlay_negotiate (GstBaseTextOverlay * overlay, GstCaps * caps) /* Check if upstream caps have meta */ if ((f = gst_caps_get_features (caps, 0))) { - caps_has_meta = gst_caps_features_contains (f, + upstream_has_meta = gst_caps_features_contains (f, GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION); }