From 90f374dd0c51aadd8d79412326467bf704bd6a4b Mon Sep 17 00:00:00 2001
From: Seppo Yli-Olli <seppo.yli-olli@iki.fi>
Date: Mon, 27 Apr 2020 11:43:57 +0300
Subject: [PATCH] openh264: memcmp return value 0 means match Commit
 e2aa76db79328b7f61536dd19d0373cf920395ad introduced version check guard for
 OpenH264 binary. There was a boolean error in memcmp so matching OpenH264 was
 erroneously rejected. Fixes #1278

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1219>
---
 ext/openh264/gstopenh264plugin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ext/openh264/gstopenh264plugin.c b/ext/openh264/gstopenh264plugin.c
index 10b0d4f071..d659a488c8 100644
--- a/ext/openh264/gstopenh264plugin.c
+++ b/ext/openh264/gstopenh264plugin.c
@@ -47,7 +47,7 @@ plugin_init (GstPlugin * plugin)
    * ABI without changing the SONAME.
    */
   OpenH264Version libver = WelsGetCodecVersion ();
-  if (memcmp (&libver, &g_stCodecVersion, sizeof (libver))) {
+  if (memcmp (&libver, &g_stCodecVersion, sizeof (libver)) == 0) {
     gst_element_register (plugin, "openh264dec", GST_RANK_MARGINAL,
         GST_TYPE_OPENH264DEC);
     gst_element_register (plugin, "openh264enc", GST_RANK_MARGINAL,