From 8f094a1cc88f76ebdb3814a2fef87cae78648ba4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Fr=C3=B6brant?= Date: Thu, 23 Feb 2023 14:26:27 +0000 Subject: [PATCH] curlhttpsink: HTTP code in transfer error details There is currently no easy way for an application to distinguish between different resource write errors being set in the curlhttpsink. Add HTTP status code as error details on transfer failure. Part-of: --- subprojects/gst-plugins-bad/ext/curl/gstcurlhttpsink.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-bad/ext/curl/gstcurlhttpsink.c b/subprojects/gst-plugins-bad/ext/curl/gstcurlhttpsink.c index 43f80f2f34..8ae2676a81 100644 --- a/subprojects/gst-plugins-bad/ext/curl/gstcurlhttpsink.c +++ b/subprojects/gst-plugins-bad/ext/curl/gstcurlhttpsink.c @@ -450,8 +450,9 @@ gst_curl_http_sink_transfer_verify_response_code (GstCurlBaseSink * bcsink) GST_DEBUG_OBJECT (sink, "response code: %ld", resp); if (resp < 100 || resp >= 300) { - bcsink->error = g_strdup_printf ("HTTP response error: (received: %ld)", - resp); + GST_ELEMENT_ERROR_WITH_DETAILS (sink, RESOURCE, WRITE, + ("HTTP response error code: %ld", resp), (NULL), ("http-status-code", + G_TYPE_UINT, (guint) resp, NULL)); return FALSE; }