From 8b1eeb5a6aaf596fce05f719776f2698ac7f4eb2 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Fri, 22 Jun 2007 10:12:15 +0000 Subject: [PATCH] Fix memory leaks. Original commit message from CVS: * ext/flac/gstflactag.c: (gst_flac_tag_init): * gst/interleave/deinterleave.c: (deinterleave_init), (deinterleave_sink_link): * gst/interleave/interleave.c: (interleave_init): * gst/median/gstmedian.c: (gst_median_init): * gst/oldcore/gstmultifilesrc.c: (gst_multifilesrc_init): Fix memory leaks. * tests/check/elements/id3demux.c: (pad_added_cb): Remove unused variable. --- ChangeLog | 12 ++++++++++++ ext/flac/gstflactag.c | 6 ++---- gst/median/gstmedian.c | 7 ++----- gst/oldcore/gstmultifilesrc.c | 4 +--- tests/check/elements/id3demux.c | 1 - 5 files changed, 17 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index be8b06425b..4316540e80 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +2007-06-22 Edward Hervey + + * ext/flac/gstflactag.c: (gst_flac_tag_init): + * gst/interleave/deinterleave.c: (deinterleave_init), + (deinterleave_sink_link): + * gst/interleave/interleave.c: (interleave_init): + * gst/median/gstmedian.c: (gst_median_init): + * gst/oldcore/gstmultifilesrc.c: (gst_multifilesrc_init): + Fix memory leaks. + * tests/check/elements/id3demux.c: (pad_added_cb): + Remove unused variable. + 2007-06-21 Jan Schmidt * ext/gconf/gconf.h: diff --git a/ext/flac/gstflactag.c b/ext/flac/gstflactag.c index db0fa2a496..247e1dea2f 100644 --- a/ext/flac/gstflactag.c +++ b/ext/flac/gstflactag.c @@ -243,15 +243,13 @@ gst_flac_tag_init (GstFlacTag * tag) { /* create the sink and src pads */ tag->sinkpad = - gst_pad_new_from_template (gst_static_pad_template_get - (&flac_tag_sink_template), "sink"); + gst_pad_new_from_static_template (&flac_tag_sink_template, "sink"); gst_element_add_pad (GST_ELEMENT (tag), tag->sinkpad); gst_pad_set_chain_function (tag->sinkpad, GST_DEBUG_FUNCPTR (gst_flac_tag_chain)); tag->srcpad = - gst_pad_new_from_template (gst_static_pad_template_get - (&flac_tag_src_template), "src"); + gst_pad_new_from_static_template (&flac_tag_src_template, "src"); gst_element_add_pad (GST_ELEMENT (tag), tag->srcpad); tag->buffer = NULL; diff --git a/gst/median/gstmedian.c b/gst/median/gstmedian.c index e16cdef6e1..2da75fe884 100644 --- a/gst/median/gstmedian.c +++ b/gst/median/gstmedian.c @@ -162,16 +162,13 @@ void gst_median_init (GstMedian * median) { median->sinkpad = - gst_pad_new_from_template (gst_static_pad_template_get - (&median_sink_factory), "sink"); + gst_pad_new_from_static_template (&media_sink_factory, "sink"); gst_pad_set_getcaps_function (median->sinkpad, gst_pad_proxy_getcaps); gst_pad_set_link_function (median->sinkpad, gst_median_link); gst_pad_set_chain_function (median->sinkpad, gst_median_chain); gst_element_add_pad (GST_ELEMENT (median), median->sinkpad); - median->srcpad = - gst_pad_new_from_template (gst_static_pad_template_get - (&median_src_factory), "src"); + median->srcpad = gst_pad_new_from_static_template (&media_src_factory, "src"); gst_pad_set_getcaps_function (median->srcpad, gst_pad_proxy_getcaps); gst_pad_set_link_function (median->sinkpad, gst_median_link); gst_element_add_pad (GST_ELEMENT (median), median->srcpad); diff --git a/gst/oldcore/gstmultifilesrc.c b/gst/oldcore/gstmultifilesrc.c index 74f0cee1a5..4dbd75d1d7 100644 --- a/gst/oldcore/gstmultifilesrc.c +++ b/gst/oldcore/gstmultifilesrc.c @@ -130,9 +130,7 @@ gst_multifilesrc_init (GstMultiFileSrc * multifilesrc, { /* GST_OBJECT_FLAG_SET (filesrc, GST_SRC_); */ - multifilesrc->srcpad = - gst_pad_new_from_template (gst_static_pad_template_get (&srctemplate), - "src"); + multifilesrc->srcpad = gst_pad_new_from_static_template (&srctemplate, "src"); gst_pad_set_get_function (multifilesrc->srcpad, gst_multifilesrc_get); /* gst_pad_set_getregion_function (multifilesrc->srcpad,gst_multifilesrc_get_region); */ gst_element_add_pad (GST_ELEMENT (multifilesrc), multifilesrc->srcpad); diff --git a/tests/check/elements/id3demux.c b/tests/check/elements/id3demux.c index 125cc5245f..d0f385d98c 100644 --- a/tests/check/elements/id3demux.c +++ b/tests/check/elements/id3demux.c @@ -28,7 +28,6 @@ static void pad_added_cb (GstElement * id3demux, GstPad * pad, GstBin * pipeline) { GstElement *sink; - GstPad *sinkpad; sink = gst_bin_get_by_name (pipeline, "fakesink"); fail_unless (gst_element_link (id3demux, sink));