FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

avimux: Avoid using freed variable

Browse Source 
the name variable might have been attributed to pad_name, make sure we
free it only *after* pad_name has been used.

Coverity CID : 1265775
This commit is contained in:
Edward Hervey 2015-01-23 15:13:55 +01:00
parent c88e042458
commit 8abfd9d720
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gst/avi/gstavimux.c
View File

@ -997,8 +997,6 @@ gst_avi_mux_request_new_pad (GstElement * element,
newpad = gst_pad_new_from_template (templ, pad_name); newpad = gst_pad_new_from_template (templ, pad_name);
g_free (name);
avipad->collect = gst_collect_pads_add_pad (avimux->collect, avipad->collect = gst_collect_pads_add_pad (avimux->collect,
newpad, sizeof (GstAviCollectData), NULL, TRUE); newpad, sizeof (GstAviCollectData), NULL, TRUE);
((GstAviCollectData *) (avipad->collect))->avipad = avipad; ((GstAviCollectData *) (avipad->collect))->avipad = avipad;
@ -1006,6 +1004,8 @@ gst_avi_mux_request_new_pad (GstElement * element,
if (!gst_element_add_pad (element, newpad)) if (!gst_element_add_pad (element, newpad))
goto pad_add_failed; goto pad_add_failed;
g_free (name);
GST_DEBUG_OBJECT (newpad, "Added new request pad"); GST_DEBUG_OBJECT (newpad, "Added new request pad");
return newpad; return newpad;
@ -1034,6 +1034,7 @@ too_many_video_pads:
pad_add_failed: pad_add_failed:
{ {
GST_WARNING_OBJECT (avimux, "Adding the new pad '%s' failed", pad_name); GST_WARNING_OBJECT (avimux, "Adding the new pad '%s' failed", pad_name);
g_free (name);
gst_object_unref (newpad); gst_object_unref (newpad);
return NULL; return NULL;
} }