From 889a3fe932253527f8131f929b321227cdefcf7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 6 Sep 2023 17:01:09 +0300 Subject: [PATCH] rtmp2: Set default flash version to NULL This is consistent with the librtmp-based old rtmp plugin and ffmpeg. While some servers require a valid flash-version, others are failing with a too long or any flash-version at all. By changing to the same default as in the old plugin and in ffmpeg, GStreamer will at least behave the same and will work and fail with the same servers without setting a flash-version. Part-of: --- subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json | 2 +- subprojects/gst-plugins-bad/gst/rtmp2/gstrtmp2locationhandler.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json index b8decb55d0..d377bf93ef 100644 --- a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json +++ b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json @@ -230725,7 +230725,7 @@ "construct": true, "construct-only": false, "controllable": false, - "default": "LNX 10,0,32,18", + "default": "NULL", "mutable": "null", "readable": true, "type": "gchararray", diff --git a/subprojects/gst-plugins-bad/gst/rtmp2/gstrtmp2locationhandler.c b/subprojects/gst-plugins-bad/gst/rtmp2/gstrtmp2locationhandler.c index 67df9a6b18..a932a9fe8e 100644 --- a/subprojects/gst-plugins-bad/gst/rtmp2/gstrtmp2locationhandler.c +++ b/subprojects/gst-plugins-bad/gst/rtmp2/gstrtmp2locationhandler.c @@ -33,7 +33,7 @@ #define DEFAULT_PASSWORD NULL #define DEFAULT_AUTHMOD GST_RTMP_AUTHMOD_AUTO #define DEFAULT_TIMEOUT 5 -#define DEFAULT_FLASH_VERSION "LNX 10,0,32,18" +#define DEFAULT_FLASH_VERSION NULL G_DEFINE_INTERFACE (GstRtmpLocationHandler, gst_rtmp_location_handler, 0);