FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

videofilter: Fix the crash in propose_allocation

Browse Source 
Always set a buffer pool if none is provided and don't
set/unref a NULL buffer pool on the query.

https://bugzilla.gnome.org/show_bug.cgi?id=681436
This commit is contained in:
Sreerenj Balachandran 2012-08-08 12:06:45 +03:00 committed by Sebastian Dröge
parent fc37cf5779
commit 8707546345
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gst-libs/gst/video/gstvideofilter.c
View File

@ -59,7 +59,6 @@ gst_video_filter_propose_allocation (GstBaseTransform * trans,
GstVideoInfo info;
GstBufferPool *pool;
GstCaps *caps;
gboolean need_pool;
guint size;
if (!GST_BASE_TRANSFORM_CLASS (parent_class)->propose_allocation (trans,
@ -70,7 +69,7 @@ gst_video_filter_propose_allocation (GstBaseTransform * trans,
if (decide_query == NULL)
return TRUE;
gst_query_parse_allocation (query, &caps, &need_pool);
gst_query_parse_allocation (query, &caps, NULL);
if (caps == NULL)
return FALSE;
@ -80,7 +79,7 @@ gst_video_filter_propose_allocation (GstBaseTransform * trans,
size = GST_VIDEO_INFO_SIZE (&info);
if (need_pool) {
if (gst_query_get_n_allocation_pools (query) < 0) {
GstStructure *structure;
static GstAllocationParams params = { 0, 0, 0, 15, };
@ -92,13 +91,11 @@ gst_video_filter_propose_allocation (GstBaseTransform * trans,
if (!gst_buffer_pool_set_config (pool, structure))
goto config_failed;
} else
pool = NULL;
gst_query_add_allocation_pool (query, pool, size, 0, 0);
gst_object_unref (pool);
gst_query_add_allocation_meta (query, GST_VIDEO_META_API_TYPE, NULL);
gst_query_add_allocation_pool (query, pool, size, 0, 0);
gst_object_unref (pool);
gst_query_add_allocation_meta (query, GST_VIDEO_META_API_TYPE, NULL);
}
return TRUE;