tensordecoders: address MR comments

This commit is contained in:
Daniel Morin 2025-02-14 10:38:11 -05:00 committed by Elias Rosendahl
parent e616f64152
commit 83d685054b

View File

@ -586,11 +586,6 @@ gst_yolo_tensor_decoder_set_caps (GstBaseTransform * trans, GstCaps * incaps,
return FALSE;
}
if (gst_base_transform_is_passthrough (trans)) {
GST_ERROR_OBJECT (self, "Failed. Can't handle passthrough");
return FALSE;
}
return TRUE;
}
@ -882,8 +877,6 @@ gst_yolo_tensor_decoder_decode_masks_f32 (GstYoloTensorDecoder * self,
GstTensor * masks_tensor, GstTensor * logits_tensor,
GstAnalyticsRelationMeta * rmeta)
{
/*guint batch_size = masks_tensor->dims[0]; */
/*guint num_masks = masks_tensor->dims[1]; */
GstMapInfo map_info_masks, map_info_logits, out_mask_info;
gfloat *candidate, **candidates, iou, *data_logits, confid = -1.0;
gboolean rv, keep;
@ -897,8 +890,10 @@ gst_yolo_tensor_decoder_decode_masks_f32 (GstYoloTensorDecoder * self,
ConfidenceRange c_range;
gsize max_class_offset = 0, class_index;
GQuark class_quark = OOI_CLASS_ID;
GstFlowReturn flowret;
/* Retrieve memory at index 0 and map it in READ mode */
/* Retrieve memory at index 0 and map it in READWRITE mode */
masks_tensor->data = gst_buffer_make_writable (masks_tensor->data);
rv = gst_buffer_map (masks_tensor->data, &map_info_masks, GST_MAP_READWRITE);
g_assert (rv);
@ -909,18 +904,17 @@ gst_yolo_tensor_decoder_decode_masks_f32 (GstYoloTensorDecoder * self,
GST_LOG_OBJECT (self, "Mask Tensor shape dims %zu", masks_tensor->num_dims);
/* Trace masks tensor dimensions */
if (gst_debug_category_get_threshold (GST_CAT_DEFAULT) >= GST_LEVEL_TRACE) {
/* Trace masks tensor dimensions */
for (gsize i = 0; i < masks_tensor->num_dims; i++) {
GST_TRACE_OBJECT (self, "Masks Tensor dim %zu: %zu", i,
masks_tensor->dims[i]);
}
}
/* Trace masks tensor dimensions */
if (gst_debug_category_get_threshold (GST_CAT_DEFAULT) >= GST_LEVEL_TRACE) {
/* Trace tensor dimensions */
for (gsize i = 0; i < logits_tensor->num_dims; i++) {
GST_TRACE_OBJECT (self, "Masks Tensor dim %zu: %zu", i,
GST_TRACE_OBJECT (self, "Logits Tensor dim %zu: %zu", i,
logits_tensor->dims[i]);
}
}
@ -1092,9 +1086,9 @@ gst_yolo_tensor_decoder_decode_masks_f32 (GstYoloTensorDecoder * self,
bb_mask.h = self->bb2mask_gain * bb1.h;
mask_buf = NULL;
g_assert (gst_buffer_pool_acquire_buffer (self->mask_pool,
&mask_buf, NULL) == GST_FLOW_OK);
g_assert (GST_IS_BUFFER (mask_buf));
flowret = gst_buffer_pool_acquire_buffer (self->mask_pool, &mask_buf,
NULL);
g_assert (flowret == GST_FLOW_OK);
GstVideoMeta *vmeta = gst_buffer_get_video_meta (mask_buf);
g_assert (vmeta != NULL);
vmeta->width = bb_mask.w;