From 7bb6ce352b8015cd6855ab5dda16e4cba3318a15 Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" Date: Mon, 5 Nov 2018 12:37:21 +0100 Subject: [PATCH] dtlsconnection: Replace if-else chain with switch A more idiomatic construct for testing a bunch of integers. --- ext/dtls/gstdtlsconnection.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/ext/dtls/gstdtlsconnection.c b/ext/dtls/gstdtlsconnection.c index 0242aebc54..a6db163afa 100644 --- a/ext/dtls/gstdtlsconnection.c +++ b/ext/dtls/gstdtlsconnection.c @@ -721,23 +721,24 @@ openssl_poll (GstDtlsConnection * self) log_state (self, "poll: after handshake"); - if (ret == 1) { - if (!self->priv->keys_exported) { - GST_INFO_OBJECT (self, - "handshake just completed successfully, exporting keys"); - export_srtp_keys (self); - } else { - GST_INFO_OBJECT (self, "handshake is completed"); - } - return; - } else { - if (ret == 0) { + switch (ret) { + case 1: + if (!self->priv->keys_exported) { + GST_INFO_OBJECT (self, + "handshake just completed successfully, exporting keys"); + export_srtp_keys (self); + } else { + GST_INFO_OBJECT (self, "handshake is completed"); + } + return; + case 0: GST_DEBUG_OBJECT (self, "do_handshake encountered EOF"); - } else if (ret == -1) { + break; + case -1: GST_DEBUG_OBJECT (self, "do_handshake encountered BIO error"); - } else { + break; + default: GST_DEBUG_OBJECT (self, "do_handshake returned %d", ret); - } } error = SSL_get_error (self->priv->ssl, ret);