From 7b6ba90416ffe63cb6f115920772324b34acacde Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Olivier=20Cr=C3=AAte?= Date: Sun, 16 Feb 2025 20:07:48 -0500 Subject: [PATCH] analyticsmeta: Avoid crash when adding Mtd with NULL Mtd structure It's documented that you don't need to get the position of the Mtd when adding it. Part-of: --- .../gst-libs/gst/analytics/gstanalyticsmeta.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/analytics/gstanalyticsmeta.c b/subprojects/gst-plugins-bad/gst-libs/gst/analytics/gstanalyticsmeta.c index da2f1c7b6e..a778f3ce50 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/analytics/gstanalyticsmeta.c +++ b/subprojects/gst-plugins-bad/gst-libs/gst/analytics/gstanalyticsmeta.c @@ -944,8 +944,10 @@ gst_analytics_relation_meta_add_mtd (GstAnalyticsRelationMeta * meta, meta->mtd_data_lookup[dest->id] = meta->offset; meta->offset += object_size; meta->length++; - rlt_mtd->id = dest->id; - rlt_mtd->meta = meta; + if (rlt_mtd) { + rlt_mtd->id = dest->id; + rlt_mtd->meta = meta; + } GST_CAT_TRACE (GST_CAT_AN_RELATION, "Add %p relatable type=%s (%" G_GSIZE_FORMAT " / %" G_GSIZE_FORMAT ").", dest, impl->name, new_size, meta->max_size);