From 79cab9f8b8fdcd417d7fea970c79fbf5b3090f7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Thu, 15 Sep 2016 13:15:22 +0200 Subject: [PATCH] player: Remove boolean return from set_subtitle_uri() It can't fail synchronously and is inconsistent with set_uri(). --- gst-libs/gst/player/gstplayer.c | 6 ++---- gst-libs/gst/player/gstplayer.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/gst-libs/gst/player/gstplayer.c b/gst-libs/gst/player/gstplayer.c index 731fcd27a0..5b2e2125e0 100644 --- a/gst-libs/gst/player/gstplayer.c +++ b/gst-libs/gst/player/gstplayer.c @@ -3187,14 +3187,12 @@ gst_player_set_uri (GstPlayer * self, const gchar * val) * * Sets the external subtitle URI. */ -gboolean +void gst_player_set_subtitle_uri (GstPlayer * self, const gchar * suburi) { - g_return_val_if_fail (GST_IS_PLAYER (self), FALSE); + g_return_if_fail (GST_IS_PLAYER (self)); g_object_set (self, "suburi", suburi, NULL); - - return TRUE; } /** diff --git a/gst-libs/gst/player/gstplayer.h b/gst-libs/gst/player/gstplayer.h index 1159d9ad3d..0ac66beb13 100644 --- a/gst-libs/gst/player/gstplayer.h +++ b/gst-libs/gst/player/gstplayer.h @@ -115,7 +115,7 @@ void gst_player_set_uri (GstPlayer * player, const gchar * uri); gchar * gst_player_get_subtitle_uri (GstPlayer * player); -gboolean gst_player_set_subtitle_uri (GstPlayer * player, +void gst_player_set_subtitle_uri (GstPlayer * player, const gchar *uri); GstClockTime gst_player_get_position (GstPlayer * player);