From 78d9d8478d88f2bb2053d7900e1a3d6797688d8d Mon Sep 17 00:00:00 2001 From: Haihua Hu Date: Thu, 20 Apr 2023 16:41:11 +0800 Subject: [PATCH] gstplay: fix critical log when enable playbin3 when play rtsp stream with playbin3 enabled, there are some critical logs: g_object_get_is_valid_property: object class 'GstPlayBin3' has no property named 'n-video' g_object_get_is_valid_property: object class 'GstPlayBin3' has no property named 'n-audio' g_object_get_is_valid_property: object class 'GstPlayBin3' has no property named 'n-text' self->collection could be NULL when READY->PAUSED if the pipeline is live, then it will fallback to query playbin2's property, we can call gst_play_streams_info_create_from_collection directly, it will check self->collection internal. Part-of: --- subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c index c88d8e94c2..6c6653987a 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c +++ b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c @@ -2389,7 +2389,7 @@ gst_play_media_info_create (GstPlay * self) gst_query_parse_seeking (query, NULL, &media_info->seekable, NULL, NULL); gst_query_unref (query); - if (self->use_playbin3 && self->collection) { + if (self->use_playbin3) { gst_play_streams_info_create_from_collection (self, media_info, self->collection); } else {