From 705ffb413544e1627edc5547da812dcdefc97a07 Mon Sep 17 00:00:00 2001 From: Andy Wingo Date: Tue, 11 Sep 2007 11:49:50 +0000 Subject: [PATCH] gst/gstmodule.c (DL_EXPORT): Remove the atexit(gst_deinit). Original commit message from CVS: 2007-09-11 Andy Wingo * gst/gstmodule.c (DL_EXPORT): Remove the atexit(gst_deinit). Atexit handlers are run after python has finalized (see Py_Exit in pythonrun.c), but gst_deinit can potentially call back into python e.g. for python-defined plugins. Not sure how other people are avoiding this segfault, but I see it all the time on Gusty x86-64 with Flumotion. --- ChangeLog | 9 +++++++++ common | 2 +- gst/gstmodule.c | 2 -- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index b68f0fa8d4..a7c8959387 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2007-09-11 Andy Wingo + + * gst/gstmodule.c (DL_EXPORT): Remove the atexit(gst_deinit). + Atexit handlers are run after python has finalized (see Py_Exit in + pythonrun.c), but gst_deinit can potentially call back into python + e.g. for python-defined plugins. Not sure how other people are + avoiding this segfault, but I see it all the time on Gusty x86-64 + with Flumotion. + 2007-08-16 Stefan Kost * ChangeLog: diff --git a/common b/common index b3fe2a25c1..7675278046 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit b3fe2a25c1cd0f4b021795d0db7330aeb338da7c +Subproject commit 76752780462a3c4da712d56d54c45402144b3d0f diff --git a/gst/gstmodule.c b/gst/gstmodule.c index 06563c02b2..c0c969c95a 100644 --- a/gst/gstmodule.c +++ b/gst/gstmodule.c @@ -266,8 +266,6 @@ init_gst (void) g_timeout_add_full (0, 100, python_do_pending_calls, NULL, NULL); - atexit(gst_deinit); - if (PyErr_Occurred ()) { Py_FatalError ("can't initialize module gst"); }