FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tmplayer: Don't append NULL + 1 to the string buffer when parsing lines without text

Browse Source 
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4417
Fixes CVE-2025-47808

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9132>
This commit is contained in:
Sebastian Dröge 2025-05-08 09:04:52 +03:00 committed by GStreamer Marge Bot
parent 48bf6a92d7
commit 6b19f11751
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
subprojects/gst-plugins-base/gst/subparse/tmplayerparse.c
View File

@ -125,7 +125,9 @@ tmplayer_parse_line (ParserState * state, const gchar * line, guint line_num)
* durations from the start times anyway, so as long as the parser just
* forwards state->start_time by duration after it pushes the line we
* are about to return it will all be good. */
g_string_append (state->buf, text_start + 1);
if (text_start) {
g_string_append (state->buf, text_start + 1);
}
} else if (line_num > 0) {
GST_WARNING ("end of subtitle unit but no valid start time?!");
}