FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mpegtsmux: Caps event fails with stream type change error

Browse Source 
If mpegtsmux receives the same caps again, it wrongly claims the stream
type changed:

  error: Stream type change from 06 to 8f not supported

This adds a unit test that demonstrate the issue in the very hacky way.
I have seen this happening with the below pipeline when upstream caps
changes. Since the caps filter fixates the caps received by opusenc and
mpegtsmux, the stream type cannot change.

  ...
  ! audioconvert
  ! audio/x-raw,format=S16LE,channels=2,rate=48000
  ! opusenc bitrate=128000
  ! mpegtsmux

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9430>
This commit is contained in:
Xavier Claessens 2025-07-23 11:37:15 -04:00 committed by Jan Schmidt
parent 80949e1ca6
commit 6a9da23bbf
1 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
subprojects/gst-plugins-bad/tests/check/elements/mpegtsmux.c
View File

@ -586,6 +586,57 @@ GST_START_TEST (test_keyframe_flag_propagation)
GST_END_TEST;
static GstBusSyncReply
caps_noop_change_bus_cb (GstBus * bus, GstMessage * message, gpointer user_data)
{
if (GST_MESSAGE_TYPE (message) == GST_MESSAGE_ERROR) {
GST_ERROR ("Got bus message %" GST_PTR_FORMAT, message);
fail_unless (GST_MESSAGE_TYPE (message) != GST_MESSAGE_ERROR);
}
return GST_BUS_PASS;
}
GST_START_TEST (test_caps_noop_change)
{
GstElement *pipeline =
gst_parse_launch
("audiotestsrc ! opusenc ! .sink_65 mpegtsmux name=mux ! fakesink",
NULL);
fail_unless (pipeline != NULL, "Could not create pipeline");
/* Check that we do not receive any ERROR message */
GstBus *bus = gst_element_get_bus (pipeline);
gst_bus_set_sync_handler (bus, caps_noop_change_bus_cb, NULL, NULL);
gst_object_unref (bus);
/* Wait for the pipeline to be playing */
gst_element_set_state (pipeline, GST_STATE_PLAYING);
fail_unless (gst_element_get_state (pipeline, NULL, NULL,
GST_CLOCK_TIME_NONE) == GST_STATE_CHANGE_SUCCESS);
/* Resend the same caps, this used to post an ERROR message on the bus:
* error: Stream type change from 06 to 8f not supported */
GstElement *mux = gst_bin_get_by_name (GST_BIN (pipeline), "mux");
fail_unless (mux != NULL);
GstPad *sinkpad = gst_element_get_static_pad (mux, "sink_65");
fail_unless (sinkpad != NULL);
GstEvent *caps_event = gst_pad_get_sticky_event (sinkpad, GST_EVENT_CAPS, 0);
gst_pad_send_event (sinkpad, caps_event);
gst_object_unref (sinkpad);
gst_object_unref (mux);
/* Wait for the caps event to be processed */
g_usleep (1000);
gst_element_set_state (pipeline, GST_STATE_NULL);
gst_object_unref (pipeline);
}
GST_END_TEST;
static Suite *
mpegtsmux_suite (void)
{
@ -602,6 +653,7 @@ mpegtsmux_suite (void)
tcase_add_test (tc_chain, test_reappearing_pad_while_playing);
tcase_add_test (tc_chain, test_reappearing_pad_while_stopped);
tcase_add_test (tc_chain, test_unused_pad);
tcase_add_test (tc_chain, test_caps_noop_change);
return s;
}