From 6921405f400a941037b3c2f0ef8f346549f30c18 Mon Sep 17 00:00:00 2001
From: Jan Schmidt <jan@centricular.com>
Date: Fri, 24 Jan 2025 18:13:24 +1100
Subject: [PATCH] onvif-media-factory: Fix pad ref leak

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8378>
---
 .../gst/rtsp-server/rtsp-onvif-media-factory.c                | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/subprojects/gst-rtsp-server/gst/rtsp-server/rtsp-onvif-media-factory.c b/subprojects/gst-rtsp-server/gst/rtsp-server/rtsp-onvif-media-factory.c
index 88f9b50c4b..7846abd412 100644
--- a/subprojects/gst-rtsp-server/gst/rtsp-server/rtsp-onvif-media-factory.c
+++ b/subprojects/gst-rtsp-server/gst/rtsp-server/rtsp-onvif-media-factory.c
@@ -270,7 +270,9 @@ gst_rtsp_onvif_media_factory_create_element (GstRTSPMediaFactory * factory,
     }
 
     depay_ghostpad = gst_ghost_pad_new ("sink", depay_pad);
-    gst_element_add_pad (backchannel_bin, depay_ghostpad);
+    gst_object_unref (depay_pad);
+
+    gst_element_add_pad (backchannel_bin, depay_ghostpad);      // Takes ownership of depay_ghostpad
 
     gst_bin_add (GST_BIN (element), backchannel_bin);
   }