From 68baaf19c3656cc8c1f87aed3e035d42cda7a288 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Thu, 2 Oct 2014 16:46:25 +0300 Subject: [PATCH] openh264: Add FIXME comment about missing API in openh264 --- ext/openh264/gstopenh264dec.cpp | 3 +++ ext/openh264/gstopenh264enc.cpp | 3 +++ 2 files changed, 6 insertions(+) diff --git a/ext/openh264/gstopenh264dec.cpp b/ext/openh264/gstopenh264dec.cpp index 2bb317a8e2..83fc881d44 100644 --- a/ext/openh264/gstopenh264dec.cpp +++ b/ext/openh264/gstopenh264dec.cpp @@ -303,6 +303,9 @@ static GstFlowReturn gst_openh264dec_handle_frame(GstVideoDecoder *decoder, GstV return GST_FLOW_EOS; } + /* FIXME: openh264 has no way for us to get a connection + * between the input and output frames, we just have to + * guess based on the input */ frame = get_oldest_pts_frame (decoder); if (!frame) { /* Can only happen in finish() */ diff --git a/ext/openh264/gstopenh264enc.cpp b/ext/openh264/gstopenh264enc.cpp index db6afac9ac..9a77eff7d9 100644 --- a/ext/openh264/gstopenh264enc.cpp +++ b/ext/openh264/gstopenh264enc.cpp @@ -662,6 +662,9 @@ static GstFlowReturn gst_openh264enc_handle_frame(GstVideoEncoder *encoder, GstV frame = NULL; } + /* FIXME: openh264 has no way for us to get a connection + * between the input and output frames, we just have to + * guess based on the input */ frame = gst_video_encoder_get_oldest_frame(base_encoder); if (!frame) { GST_ELEMENT_ERROR(openh264enc, STREAM, ENCODE, ("Could not encode frame"), ("openh264enc returned %d", ret));