From 61fc65475ee0593c6c53bf32167e39c99c8adb22 Mon Sep 17 00:00:00 2001
From: Jochen Henneberg <jochen@centricular.com>
Date: Tue, 28 Jan 2025 11:42:19 +0100
Subject: [PATCH] validate: 'bat' is optional

If 'bat' is not installed G_IS_SUBPROCESS (subprocess) fails and the
error message is misleading.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8376>
---
 .../validate/gst/validate/flow/gstvalidateflow.c           | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/subprojects/gst-devtools/validate/gst/validate/flow/gstvalidateflow.c b/subprojects/gst-devtools/validate/gst/validate/flow/gstvalidateflow.c
index 7b23955174..f63253b038 100644
--- a/subprojects/gst-devtools/validate/gst/validate/flow/gstvalidateflow.c
+++ b/subprojects/gst-devtools/validate/gst/validate/flow/gstvalidateflow.c
@@ -479,8 +479,11 @@ run_diff (const gchar * expected_file, const gchar * actual_file)
           "diff", "--paging", "never", "--color", colored ? "always" : "never",
           fname, NULL);
 
-      g_subprocess_communicate_utf8 (process2, NULL, NULL, &tmpstdout, NULL,
-          &error);
+      if (!error) {
+        g_subprocess_communicate_utf8 (process2, NULL, NULL, &tmpstdout, NULL,
+            &error);
+      }
+
       if (!error) {
         g_free (stdout_text);
         stdout_text = tmpstdout;