From 60afc6cc95c1a66c47334de968b2bc27e04493be Mon Sep 17 00:00:00 2001
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date: Thu, 6 Jul 2023 12:01:21 -0400
Subject: [PATCH] python: Fix variable name for gst_element_factory_make
In order to use keyword argument, the names shoudl match the documentation. Both
arguments name was changed in the override.
Fixes: #2779
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4982>
---
subprojects/gst-python/gi/overrides/Gst.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/subprojects/gst-python/gi/overrides/Gst.py b/subprojects/gst-python/gi/overrides/Gst.py
index 139babee24..8270358e4b 100644
--- a/subprojects/gst-python/gi/overrides/Gst.py
+++ b/subprojects/gst-python/gi/overrides/Gst.py
@@ -83,14 +83,14 @@ class Bin(Gst.Bin):
if not Gst.Bin.add(self, arg):
raise AddError(arg)
- def make_and_add(self, factory_name, instance_name=None):
+ def make_and_add(self, factoryname, name=None):
'''
@raises: Gst.AddError
'''
- elem = Gst.ElementFactory.make(factory_name, instance_name)
+ elem = Gst.ElementFactory.make(factoryname, name)
if not elem:
raise AddError(
- 'No such element: {}'.format(factory_name))
+ 'No such element: {}'.format(factoryname))
self.add(elem)
return elem
@@ -288,8 +288,8 @@ class ElementFactory(Gst.ElementFactory):
return self.get_metadata("klass")
@classmethod
- def make(cls, factory_name, instance_name=None):
- return Gst.ElementFactory.make(factory_name, instance_name)
+ def make(cls, factoryname, name=None):
+ return Gst.ElementFactory.make(factoryname, name)
class Pipeline(Gst.Pipeline):