From 5dbee0c39c96f89d4af28ddc9a8622b861e41de0 Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Mon, 24 Jan 2011 10:08:17 -0300 Subject: [PATCH] tests: imagecapturebin: Only run a test if -good is 0.10.27 or newer One test on imagecapturebin requires dcbba0932dc579abd6aab4460fa1a416374eda1b on good that was released on 0.10.27. https://bugzilla.gnome.org/show_bug.cgi?id=640286 --- tests/check/elements/imagecapturebin.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/tests/check/elements/imagecapturebin.c b/tests/check/elements/imagecapturebin.c index 6a1ecee721..34f71c7017 100644 --- a/tests/check/elements/imagecapturebin.c +++ b/tests/check/elements/imagecapturebin.c @@ -380,14 +380,28 @@ GST_END_TEST; static Suite * imagecapturebin_suite (void) { + GstElementFactory *jpegenc_factory; + Suite *s = suite_create ("imagecapturebin"); TCase *tc_chain = tcase_create ("general"); + jpegenc_factory = gst_element_factory_find ("jpegenc"); + suite_add_tcase (s, tc_chain); - tcase_add_test (tc_chain, test_simple_capture); - tcase_add_test (tc_chain, test_multiple_captures_different_caps); - tcase_add_test (tc_chain, test_setting_encoder); - tcase_add_test (tc_chain, test_setting_muxer); + if (jpegenc_factory) { + tcase_add_test (tc_chain, test_simple_capture); + + /* only adds this test if jpegenc contains the fix for its getcaps + * The fix on good: dcbba0932dc579abd6aab4460fa1a416374eda1b */ + if (gst_plugin_feature_check_version (jpegenc_factory, 0, 10, 27)) + tcase_add_test (tc_chain, test_multiple_captures_different_caps); + else + GST_WARNING ("Skipped test that needs gst-plugins-good 0.10.27"); + + tcase_add_test (tc_chain, test_setting_encoder); + tcase_add_test (tc_chain, test_setting_muxer); + } else + GST_WARNING ("Skipped imagecapturebin tests because jpegenc is missing"); return s; }