From 593ed6f3d74d01920e8c0172fdbbc4709721c5e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Thu, 30 Jun 2016 23:33:38 +0200 Subject: [PATCH] openh264enc: Remove meaningless drop bitrate handling This doesn't even have a property. --- ext/openh264/gstopenh264enc.cpp | 11 ----------- ext/openh264/gstopenh264enc.h | 1 - 2 files changed, 12 deletions(-) diff --git a/ext/openh264/gstopenh264enc.cpp b/ext/openh264/gstopenh264enc.cpp index 1541b4450f..b90893659c 100644 --- a/ext/openh264/gstopenh264enc.cpp +++ b/ext/openh264/gstopenh264enc.cpp @@ -165,7 +165,6 @@ static void gst_openh264enc_set_rate_control (GstOpenh264Enc * openh264enc, #define DEFAULT_MAX_BITRATE (UNSPECIFIED_BIT_RATE) #define DEFAULT_GOP_SIZE (90) #define DEFAULT_MAX_SLICE_SIZE (1500000) -#define DROP_BITRATE 20000 #define START_FRAMERATE 30 #define DEFAULT_USAGE_TYPE CAMERA_VIDEO_REAL_TIME #define DEFAULT_RATE_CONTROL RC_QUALITY_MODE @@ -364,7 +363,6 @@ gst_openh264enc_init (GstOpenh264Enc * openh264enc) openh264enc->time_per_frame = GST_SECOND / openh264enc->framerate; openh264enc->frame_count = 0; openh264enc->previous_timestamp = 0; - openh264enc->drop_bitrate = DROP_BITRATE; openh264enc->enable_denoise = DEFAULT_ENABLE_DENOISE; openh264enc->enable_frame_skip = DEFAULT_ENABLE_FRAME_SKIP; openh264enc->deblocking_mode = DEFAULT_DEBLOCKING_MODE; @@ -786,15 +784,6 @@ gst_openh264enc_handle_frame (GstVideoEncoder * encoder, } } - if (openh264enc->bitrate <= openh264enc->drop_bitrate) { - GST_LOG_OBJECT (openh264enc, "Dropped frame due to too low bitrate"); - if (frame) { - gst_video_encoder_finish_frame (encoder, frame); - delete src_pic; - } - return GST_FLOW_OK; - } - if (frame) { gst_video_frame_map (&video_frame, &openh264enc->input_state->info, frame->input_buffer, GST_MAP_READ); diff --git a/ext/openh264/gstopenh264enc.h b/ext/openh264/gstopenh264enc.h index 9f20569112..4bd0eb7f7d 100644 --- a/ext/openh264/gstopenh264enc.h +++ b/ext/openh264/gstopenh264enc.h @@ -73,7 +73,6 @@ struct _GstOpenh264Enc gboolean enable_denoise; gboolean enable_frame_skip; GstVideoCodecState *input_state; - guint32 drop_bitrate; guint64 time_per_frame; guint64 frame_count; guint64 previous_timestamp;