From 5835f2aa8d53cb35f4a00dff0f69feffbaba3309 Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Thu, 29 Apr 2021 21:12:42 +1000 Subject: [PATCH] webrtc: advertise support for transport-cc rtcp-fb by default Still requires explicit enabling by the application through the header extension on all the relevant payloaders. Part-of: --- ext/webrtc/gstwebrtcbin.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ext/webrtc/gstwebrtcbin.c b/ext/webrtc/gstwebrtcbin.c index a13bed2762..cde8a246bb 100644 --- a/ext/webrtc/gstwebrtcbin.c +++ b/ext/webrtc/gstwebrtcbin.c @@ -1590,9 +1590,8 @@ _add_supported_attributes_to_caps (GstWebRTCBin * webrtc, if (!gst_structure_has_field (s, "rtcp-fb-nack-pli")) gst_structure_set (s, "rtcp-fb-nack-pli", G_TYPE_BOOLEAN, TRUE, NULL); - /* FIXME: is this needed? */ - /*if (!gst_structure_has_field (s, "rtcp-fb-transport-cc")) - gst_structure_set (s, "rtcp-fb-nack-pli", G_TYPE_BOOLEAN, TRUE, NULL); */ + if (!gst_structure_has_field (s, "rtcp-fb-transport-cc")) + gst_structure_set (s, "rtcp-fb-transport-cc", G_TYPE_BOOLEAN, TRUE, NULL); /* FIXME: codec-specific parameters? */ }