From 5828713771e1e65d76d216c5095ebc374da75462 Mon Sep 17 00:00:00 2001 From: Vineeth T M Date: Mon, 22 Jun 2015 19:30:58 +0900 Subject: [PATCH] mikmod_reader: Possible null pointer dereference: gst_reader variable is being used before actually checking if it allocated properly https://bugzilla.gnome.org/show_bug.cgi?id=751306 --- ext/mikmod/mikmod_reader.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ext/mikmod/mikmod_reader.c b/ext/mikmod/mikmod_reader.c index f8e83de177..f1c2a4356c 100644 --- a/ext/mikmod/mikmod_reader.c +++ b/ext/mikmod/mikmod_reader.c @@ -90,10 +90,12 @@ GST_READER_new (GstMikMod * mik) GST_READER *gst_reader; gst_reader = (GST_READER *) g_malloc (sizeof (GST_READER)); - gst_reader->offset = 0; - gst_reader->eof = 0; - gst_reader->mik = mik; + if (gst_reader) { + gst_reader->offset = 0; + gst_reader->eof = 0; + gst_reader->mik = mik; + gst_reader->core.Eof = &GST_READER_Eof; gst_reader->core.Read = &GST_READER_Read; gst_reader->core.Get = &GST_READER_Get;