From 55f692eff682b78c924c5d79087e9f91e4dc93bb Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Thu, 19 Jul 2012 10:54:07 +0200 Subject: [PATCH] audiodecoder: Don't assert on pad caps not being set The decoder might have been de-activated in the meantime (resulting in NULL pad caps). If the decoder really isn't configured, then it will error out further down when checking whether the GST_AUDIO_INFO_IS_VALID() https://bugzilla.gnome.org/show_bug.cgi?id=667562 --- gst-libs/gst/audio/gstaudiodecoder.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/gst-libs/gst/audio/gstaudiodecoder.c b/gst-libs/gst/audio/gstaudiodecoder.c index 74f8727958..87c3ff0b5c 100644 --- a/gst-libs/gst/audio/gstaudiodecoder.c +++ b/gst-libs/gst/audio/gstaudiodecoder.c @@ -834,9 +834,6 @@ gst_audio_decoder_finish_frame (GstAudioDecoder * dec, GstBuffer * buf, gsize size; GstFlowReturn ret = GST_FLOW_OK; - /* subclass should know what it is producing by now */ - g_return_val_if_fail (buf == NULL || gst_pad_has_current_caps (dec->srcpad), - GST_FLOW_ERROR); /* subclass should not hand us no data */ g_return_val_if_fail (buf == NULL || gst_buffer_get_size (buf) > 0, GST_FLOW_ERROR);