From 552f790e843c3cc9838efbbc3ec232d5fb1d66e2 Mon Sep 17 00:00:00 2001
From: Edward Hervey <bilboed@bilboed.com>
Date: Mon, 12 Apr 2010 18:03:20 +0200
Subject: [PATCH] check: Don't re-declare 'GList *buffers' in the tests

It's an external which lives in gstcheck.c. Redeclaring it makes some
compilers/architectures think the 'buffers' in the individual tests are
a different symbol... and therefore we end up comparing holodecks with
oranges.
---
 tests/check/elements/cmmldec.c     | 2 --
 tests/check/elements/cmmlenc.c     | 1 -
 tests/check/elements/level.c       | 1 -
 tests/check/elements/matroskamux.c | 2 --
 tests/check/elements/rganalysis.c  | 2 --
 tests/check/elements/rglimiter.c   | 2 --
 tests/check/elements/rgvolume.c    | 1 -
 tests/check/elements/spectrum.c    | 1 -
 tests/check/elements/videofilter.c | 1 -
 9 files changed, 13 deletions(-)

diff --git a/tests/check/elements/cmmldec.c b/tests/check/elements/cmmldec.c
index a7d5848ecf..1ba8fb4a1b 100644
--- a/tests/check/elements/cmmldec.c
+++ b/tests/check/elements/cmmldec.c
@@ -92,8 +92,6 @@ static GstBus *bus;
 
 static GstFlowReturn flow;
 
-GList *buffers;
-
 static GList *current_buf;
 
 static gint64 granulerate;
diff --git a/tests/check/elements/cmmlenc.c b/tests/check/elements/cmmlenc.c
index eff12414c8..4424a72a77 100644
--- a/tests/check/elements/cmmlenc.c
+++ b/tests/check/elements/cmmlenc.c
@@ -109,7 +109,6 @@ G_STMT_START {                                                          \
   g_free (b_up);                                                        \
 } G_STMT_END;
 
-GList *buffers;
 static GList *current_buf;
 static guint64 granulerate;
 static guint8 granuleshift;
diff --git a/tests/check/elements/level.c b/tests/check/elements/level.c
index d1f744c60e..2bb4eb7d8a 100644
--- a/tests/check/elements/level.c
+++ b/tests/check/elements/level.c
@@ -25,7 +25,6 @@
 
 #include <gst/check/gstcheck.h>
 
-GList *buffers = NULL;
 gboolean have_eos = FALSE;
 
 /* For ease of programming we use globals to keep refs for our floating
diff --git a/tests/check/elements/matroskamux.c b/tests/check/elements/matroskamux.c
index efb0fb6bba..a05b2ca796 100644
--- a/tests/check/elements/matroskamux.c
+++ b/tests/check/elements/matroskamux.c
@@ -24,8 +24,6 @@
 
 #include <gst/check/gstcheck.h>
 
-GList *buffers = NULL;
-
 /* For ease of programming we use globals to keep refs for our floating
  * src and sink pads we create; otherwise we always have to do get_pad,
  * get_peer, and then remove references in every test function */
diff --git a/tests/check/elements/rganalysis.c b/tests/check/elements/rganalysis.c
index 89ff92eaa4..8c26cf3e83 100644
--- a/tests/check/elements/rganalysis.c
+++ b/tests/check/elements/rganalysis.c
@@ -61,8 +61,6 @@
 
 #include <gst/check/gstcheck.h>
 
-GList *buffers = NULL;
-
 /* For ease of programming we use globals to keep refs for our floating src and
  * sink pads we create; otherwise we always have to do get_pad, get_peer, and
  * then remove references in every test function */
diff --git a/tests/check/elements/rglimiter.c b/tests/check/elements/rglimiter.c
index 9765794b6b..6b4b96a259 100644
--- a/tests/check/elements/rglimiter.c
+++ b/tests/check/elements/rglimiter.c
@@ -24,8 +24,6 @@
 
 #include <math.h>
 
-GList *buffers = NULL;
-
 /* For ease of programming we use globals to keep refs for our floating
  * src and sink pads we create; otherwise we always have to do get_pad,
  * get_peer, and then remove references in every test function */
diff --git a/tests/check/elements/rgvolume.c b/tests/check/elements/rgvolume.c
index 28d41349fa..3add27a722 100644
--- a/tests/check/elements/rgvolume.c
+++ b/tests/check/elements/rgvolume.c
@@ -24,7 +24,6 @@
 
 #include <math.h>
 
-GList *buffers = NULL;
 GList *events = NULL;
 
 /* For ease of programming we use globals to keep refs for our floating src and
diff --git a/tests/check/elements/spectrum.c b/tests/check/elements/spectrum.c
index 2045c12a57..0eed1dc00d 100644
--- a/tests/check/elements/spectrum.c
+++ b/tests/check/elements/spectrum.c
@@ -24,7 +24,6 @@
 
 #include <gst/check/gstcheck.h>
 
-GList *buffers = NULL;
 gboolean have_eos = FALSE;
 
 /* For ease of programming we use globals to keep refs for our floating
diff --git a/tests/check/elements/videofilter.c b/tests/check/elements/videofilter.c
index f7959ec2fc..977173889f 100644
--- a/tests/check/elements/videofilter.c
+++ b/tests/check/elements/videofilter.c
@@ -25,7 +25,6 @@
 
 #include <gst/check/gstcheck.h>
 
-GList *buffers = NULL;
 gboolean have_eos = FALSE;
 
 /* For ease of programming we use globals to keep refs for our floating