From 54ce23e0cba7fe41b3fa4957360e15a99eb0515f Mon Sep 17 00:00:00 2001 From: Luis de Bethencourt Date: Thu, 8 Jan 2015 15:36:04 +0000 Subject: [PATCH] rtp: value truncated too short creates dead code type is truncated to 0-31 with "& 0x1f", but right after that it is checks if the value is equivalent to GST_H265_NAL_VPS, GST_H265_NAL_SPS, and GST_H265_NAL_PPS (which are 32, 33, and 34 respectively). Obviously, this will never be True if the value is maximum 31 after the truncation. The intention of the code was to truncate to 0-63. --- gst/rtp/gstrtph265pay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst/rtp/gstrtph265pay.c b/gst/rtp/gstrtph265pay.c index 629c6e021f..b2da44d99f 100644 --- a/gst/rtp/gstrtph265pay.c +++ b/gst/rtp/gstrtph265pay.c @@ -821,7 +821,7 @@ gst_rtp_h265_pay_decode_nal (GstRtpH265Pay * payloader, GST_DEBUG ("NAL payload len=%u", size); header = data[0]; - type = header & 0x1f; + type = header & 0x3f; /* We record the timestamp of the last SPS/PPS so * that we can insert them at regular intervals and when needed. */