From 54c5710adbe58001a66a5159af79293876c5aba0 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Mon, 21 Apr 2014 13:34:37 +0100 Subject: [PATCH] matroskamux: fix PAR fraction sanity check It was checking par_num twice, and never par_denum. Coverity 1139634 --- gst/matroska/matroska-mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst/matroska/matroska-mux.c b/gst/matroska/matroska-mux.c index 7347509002..e1472d9cbe 100644 --- a/gst/matroska/matroska-mux.c +++ b/gst/matroska/matroska-mux.c @@ -1416,7 +1416,7 @@ theora_streamheader_to_codecdata (const GValue * streamheader, hdr += 4 + 4; par_num = GST_READ_UINT32_BE (hdr) >> 8; par_denom = GST_READ_UINT32_BE (hdr + 3) >> 8; - if (par_num > 0 && par_num > 0) { + if (par_num > 0 && par_denom > 0) { if (par_num > par_denom) { videocontext->display_width = videocontext->pixel_width * par_num / par_denom;