FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glwindow_cocoa: fix window not closing (w/o user window handle)

Browse Source 
A user-supplied window handle (external_view) becomes the superView
of internal_view, which is closed with [view removeFromSuperview].
This fails silently if external_view = NULL (no handle supplied).
Call [win_internal_id close] in this case. Fixes #4432.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9049>
This commit is contained in:
F. Duncanh 2025-05-21 13:04:07 -04:00 committed by GStreamer Marge Bot
parent 224da2b947
commit 5268156447
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
subprojects/gst-plugins-base/gst-libs/gst/gl/cocoa/gstglwindow_cocoa.m
View File

@ -257,6 +257,13 @@ _close_window (gpointer * data)
[view removeFromSuperview];
if (!window_cocoa->priv->external_view) {
GstGLNSWindow *internal_win_id =
(__bridge GstGLNSWindow *) window_cocoa->priv->internal_win_id;
[internal_win_id close];
}
CFBridgingRelease (window_cocoa->priv->internal_win_id);
CFBridgingRelease (window_cocoa->priv->internal_view);
window_cocoa->priv->internal_win_id = NULL;