FaSTTUBe/GST-Tensordecoder-ov_ep
61
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vorbisdec: fix leak of header buffers

Browse Source 
handle_header_buffer() does no take ownership of
the buffer passed.

Fixes leaks in various unit tests.
This commit is contained in:
Tim-Philipp Müller 2019-03-06 09:14:04 +00:00
parent 13fc711eca
commit 50aa1622e1
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ext/vorbis/gstvorbisdec.c
View File

@ -358,6 +358,7 @@ header_read_error:
} }
} }
/* Does not take ownership of buffer */
static GstFlowReturn static GstFlowReturn
vorbis_dec_handle_header_buffer (GstVorbisDec * vd, GstBuffer * buffer) vorbis_dec_handle_header_buffer (GstVorbisDec * vd, GstBuffer * buffer)
{ {
@ -615,17 +616,20 @@ check_pending_headers (GstVorbisDec * vd)
/* All good, let's reset ourselves and process the headers */ /* All good, let's reset ourselves and process the headers */
vorbis_dec_reset ((GstAudioDecoder *) vd); vorbis_dec_reset ((GstAudioDecoder *) vd);
result = vorbis_dec_handle_header_buffer (vd, buffer1); result = vorbis_dec_handle_header_buffer (vd, buffer1);
gst_buffer_unref (buffer1);
if (result != GST_FLOW_OK) { if (result != GST_FLOW_OK) {
gst_buffer_unref (buffer3); gst_buffer_unref (buffer3);
gst_buffer_unref (buffer5); gst_buffer_unref (buffer5);
return result; return result;
} }
result = vorbis_dec_handle_header_buffer (vd, buffer3); result = vorbis_dec_handle_header_buffer (vd, buffer3);
gst_buffer_unref (buffer3);
if (result != GST_FLOW_OK) { if (result != GST_FLOW_OK) {
gst_buffer_unref (buffer5); gst_buffer_unref (buffer5);
return result; return result;
} }
result = vorbis_dec_handle_header_buffer (vd, buffer5); result = vorbis_dec_handle_header_buffer (vd, buffer5);
gst_buffer_unref (buffer5);
return result; return result;