From 50910664265ff72ea37ea0db3238f51ac56a60d4 Mon Sep 17 00:00:00 2001 From: Julien Isorce Date: Thu, 15 Dec 2011 16:18:36 +0100 Subject: [PATCH] [483/906] glelements: do not leak parent when using gst_pad_get_parent --- gst-libs/gst/gl/gstglfilter.c | 2 ++ gst/gl/gstgldownload.c | 8 +++++--- gst/gl/gstgltestsrc.c | 2 ++ gst/gl/gstglupload.c | 2 ++ 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/gst-libs/gst/gl/gstglfilter.c b/gst-libs/gst/gl/gstglfilter.c index 683792e7e8..8ea6772d61 100644 --- a/gst-libs/gst/gl/gstglfilter.c +++ b/gst-libs/gst/gl/gstglfilter.c @@ -202,6 +202,8 @@ gst_gl_filter_src_query (GstPad * pad, GstQuery * query) break; } + gst_object_unref (parent); + return res; } diff --git a/gst/gl/gstgldownload.c b/gst/gl/gstgldownload.c index 4d0e512b90..af43122721 100644 --- a/gst/gl/gstgldownload.c +++ b/gst/gl/gstgldownload.c @@ -27,7 +27,7 @@ * * Color space conversion * - * When needed, the color space conversion is made in a fragment shader using + * When needed, the color space conversion is made in a fragment shader using * one frame buffer object instance. * * @@ -48,14 +48,14 @@ * |[ * gst-launch -v gltestsrc ! gldownload ! xvimagesink * ]| A pipeline to test hardware colorspace conversion. - * Your driver must support GLSL (OpenGL Shading Language needs OpenGL >= 2.1). + * Your driver must support GLSL (OpenGL Shading Language needs OpenGL >= 2.1). * Texture RGB32 is converted to one of the 4 following format YUY2, UYVY, I420, YV12 and AYUV, * through some fragment shaders and using one framebuffer (FBO extension OpenGL >= 1.4). * MESA >= 7.1 supports GLSL but it's made in software. * |[ * gst-launch -v videotestsrc ! glupload ! gldownload ! "video/x-raw-yuv, format=(fourcc)YUY2" ! glimagesink * ]| A pipeline to test hardware colorspace conversion - * FBO and GLSL are required. + * FBO and GLSL are required. * */ @@ -236,6 +236,8 @@ gst_gl_download_src_query (GstPad * pad, GstQuery * query) break; } + gst_object_unref (download); + return res; } diff --git a/gst/gl/gstgltestsrc.c b/gst/gl/gstgltestsrc.c index 15ea18dc98..ac07a4f289 100644 --- a/gst/gl/gstgltestsrc.c +++ b/gst/gl/gstgltestsrc.c @@ -323,6 +323,8 @@ gst_gl_test_src_src_query (GstPad * pad, GstQuery * query) break; } + gst_object_unref (parent); + return res; } diff --git a/gst/gl/gstglupload.c b/gst/gl/gstglupload.c index 531ba25bdb..30cc37eca5 100644 --- a/gst/gl/gstglupload.c +++ b/gst/gl/gstglupload.c @@ -255,6 +255,8 @@ gst_gl_upload_src_query (GstPad * pad, GstQuery * query) break; } + gst_object_unref (parent); + return res; }