From 4e4f922d7acaa10e6200e22c9d27a03b66b8eaf0 Mon Sep 17 00:00:00 2001 From: Stefan Kost Date: Thu, 26 Feb 2009 17:38:47 +0200 Subject: [PATCH] rtsprange: don't leak the range in case of parsing error. Free the gstRTSPTimeRange if we don't return it. Also simplify gst_rtsp_range_free() as it is valid to pass NULL to g_free(). --- gst-libs/gst/rtsp/gstrtsprange.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/gst-libs/gst/rtsp/gstrtsprange.c b/gst-libs/gst/rtsp/gstrtsprange.c index cad31f8428..ceb5258a55 100644 --- a/gst-libs/gst/rtsp/gstrtsprange.c +++ b/gst-libs/gst/rtsp/gstrtsprange.c @@ -167,9 +167,10 @@ gst_rtsp_range_parse (const gchar * rangestr, GstRTSPTimeRange ** range) } else goto invalid; - if (ret == GST_RTSP_OK) - *range = res; + if (ret != GST_RTSP_OK) + goto invalid; + *range = res; return ret; /* ERRORS */ @@ -271,8 +272,5 @@ gst_rtsp_range_to_string (const GstRTSPTimeRange * range) void gst_rtsp_range_free (GstRTSPTimeRange * range) { - if (range == NULL) - return; - g_free (range); }