From 4dc503e1e4fdceb57482b978e7d3b6e3681700e0 Mon Sep 17 00:00:00 2001 From: Philippe Normand <philn@igalia.com> Date: Wed, 12 Jul 2023 17:08:32 +0100 Subject: [PATCH] decodebin3: Remove spurious input locking during parsebin reconfiguration Commit 22917b140ffac5208eff173321fa7cdad8976cca added extra locks in `reset_input_parsebin()` but all call sites of that function already take the input lock. Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5022> --- subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c b/subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c index a758e977bb..67b41a7832 100644 --- a/subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c +++ b/subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c @@ -1136,7 +1136,6 @@ reset_input_parsebin (GstDecodebin3 * dbin, DecodebinInput * input) GST_DEBUG_OBJECT (dbin, "Resetting %" GST_PTR_FORMAT, input->parsebin); - INPUT_LOCK (dbin); GST_STATE_LOCK (dbin); gst_element_set_state (input->parsebin, GST_STATE_NULL); input->drained = FALSE; @@ -1149,7 +1148,6 @@ reset_input_parsebin (GstDecodebin3 * dbin, DecodebinInput * input) } gst_element_sync_state_with_parent (input->parsebin); GST_STATE_UNLOCK (dbin); - INPUT_UNLOCK (dbin); }