From 4da517ae87c68355a510398d15d02856b8a048d2 Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Wed, 9 Feb 2011 19:09:24 -0300 Subject: [PATCH] wrappercamerabinsrc: Avoid fixating capture caps When setting the internal capsfilter caps for capture we should put the full caps instead of trying to fixate it ourselves. This way we let the elements (and mostly the source) select the best format instead of defaulting to what the pad fixation function picks. --- gst/camerabin2/gstwrappercamerabinsrc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/gst/camerabin2/gstwrappercamerabinsrc.c b/gst/camerabin2/gstwrappercamerabinsrc.c index d258d04f4a..cb36197991 100644 --- a/gst/camerabin2/gstwrappercamerabinsrc.c +++ b/gst/camerabin2/gstwrappercamerabinsrc.c @@ -605,9 +605,6 @@ start_image_capture (GstWrapperCameraBinSrc * self) caps = gst_pad_get_allowed_caps (self->imgsrc); - caps = gst_caps_make_writable (caps); - gst_pad_fixate_caps (self->imgsrc, caps); - gst_caps_replace (&self->image_capture_caps, caps); gst_caps_unref (caps); @@ -942,10 +939,9 @@ gst_wrapper_camera_bin_src_start_capture (GstBaseCameraSrc * camerasrc) if (src->src_zoom_filter) g_object_set (src->src_zoom_filter, "caps", NULL, NULL); + GST_DEBUG_OBJECT (src, "Getting allowed videosrc caps"); caps = gst_pad_get_allowed_caps (src->vidsrc); - caps = gst_caps_make_writable (caps); - gst_pad_fixate_caps (src->vidsrc, caps); - GST_DEBUG_OBJECT (src, "Vidsrc caps fixated to %" GST_PTR_FORMAT, caps); + GST_DEBUG_OBJECT (src, "Video src caps %" GST_PTR_FORMAT, caps); src->video_renegotiate = FALSE; g_mutex_unlock (camerasrc->capturing_mutex);