FaSTTUBe/GST-Tensordecoder-ov_ep
61
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

d3d12decoder: Workaround for NVIDIA crash on resolution change

Browse Source 
Recent NVIDIA driver seems to crash on resolution change
if ID3D12VideoDecoder and ID3D12VideoDecodeCommandList are reused.

Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4415
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8968>
This commit is contained in:
Seungha Yang 2025-05-13 01:40:57 +09:00 committed by GStreamer Marge Bot
parent 111c0a4186
commit 4d87ffb8f3
1 changed files with 13 additions and 28 deletions

41
subprojects/gst-plugins-bad/sys/d3d12/gstd3d12decoder.cpp

@ -560,18 +560,12 @@ gst_d3d12_decoder_configure (GstD3D12Decoder * decoder,
auto priv = decoder->priv; auto priv = decoder->priv;
HRESULT hr; HRESULT hr;
D3D12_VIDEO_DECODER_DESC prev_desc = { };
ComPtr < ID3D12VideoDecoder > prev_decoder;
/* Store previous encoder object and reuse if possible */
if (priv->session) {
prev_desc = priv->session->decoder_desc;
prev_decoder = priv->session->decoder;
}
gst_d3d12_decoder_drain (decoder, videodec); gst_d3d12_decoder_drain (decoder, videodec);
priv->session = nullptr; priv->session = nullptr;
/* XXX: NVIDIA driver crash if cmdlist is reused... */
priv->cmd->cl = nullptr;
if (!gst_d3d12_device_get_format (decoder->device, if (!gst_d3d12_device_get_format (decoder->device,
GST_VIDEO_INFO_FORMAT (info), &device_format) || GST_VIDEO_INFO_FORMAT (info), &device_format) ||
device_format.dxgi_format == DXGI_FORMAT_UNKNOWN) { device_format.dxgi_format == DXGI_FORMAT_UNKNOWN) {
@ -674,27 +668,18 @@ gst_d3d12_decoder_configure (GstD3D12Decoder * decoder,
session->aligned_width = GST_ROUND_UP_N (session->coded_width, alignment); session->aligned_width = GST_ROUND_UP_N (session->coded_width, alignment);
session->aligned_height = GST_ROUND_UP_N (session->coded_height, alignment); session->aligned_height = GST_ROUND_UP_N (session->coded_height, alignment);
if (prev_decoder && prev_desc.Configuration.DecodeProfile == D3D12_VIDEO_DECODER_DESC desc = { };
support.Configuration.DecodeProfile && desc.NodeMask = 0;
prev_desc.Configuration.InterlaceType == desc.Configuration = support.Configuration;
support.Configuration.InterlaceType) { hr = priv->cmd->video_device->CreateVideoDecoder (&desc,
session->decoder = prev_decoder; IID_PPV_ARGS (&session->decoder));
session->decoder_desc = prev_desc; if (!gst_d3d12_result (hr, decoder->device)) {
} else { GST_ERROR_OBJECT (decoder, "Couldn't create decoder object");
D3D12_VIDEO_DECODER_DESC desc; return GST_FLOW_ERROR;
desc.NodeMask = 0;
desc.Configuration = support.Configuration;
hr = priv->cmd->video_device->CreateVideoDecoder (&desc,
IID_PPV_ARGS (&session->decoder));
if (!gst_d3d12_result (hr, decoder->device)) {
GST_ERROR_OBJECT (decoder, "Couldn't create decoder object");
return GST_FLOW_ERROR;
}
session->decoder_desc = desc;
} }
session->decoder_desc = desc;
D3D12_VIDEO_DECODER_HEAP_DESC heap_desc; D3D12_VIDEO_DECODER_HEAP_DESC heap_desc;
heap_desc.NodeMask = 0; heap_desc.NodeMask = 0;
heap_desc.Configuration = session->support.Configuration; heap_desc.Configuration = session->support.Configuration;