Revert "pulsesink: uncork if needed upon commit"
This reverts commit 0dd46accf6d282ff07065852bd91c85c78af3394. With some audiosinks, starting the ringbuffer on the first commit causes audio glitches at startup by starting to output segments from the ringbuffer before it has been filled / fully prerolled. This doesn't usually happen with pulsesink because we map the pulseaudio ringbuffer directly, but we should keep things consistent with other sinks with regards to startup latency, plus it gives more headway to avoid glitching, should the initial 2nd segment take more than 10ms to generate. https://bugzilla.gnome.org/show_bug.cgi?id=657076
This commit is contained in:
parent
c36930535d
commit
46a3c9ac8b
@ -1516,12 +1516,6 @@ gst_pulseringbuffer_commit (GstAudioRingBuffer * buf, guint64 * sample,
|
||||
if (pbuf->paused)
|
||||
goto was_paused;
|
||||
|
||||
/* ensure running clock for whatever out there */
|
||||
if (pbuf->corked) {
|
||||
if (!gst_pulsering_set_corked (pbuf, FALSE, FALSE))
|
||||
goto uncork_failed;
|
||||
}
|
||||
|
||||
/* offset is in bytes */
|
||||
offset = *sample * bpf;
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user