From 454618e9b91b37af32ab94837a96d90ca2537a1f Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Fri, 17 Feb 2006 10:15:52 +0000 Subject: [PATCH] gst-libs/gst/audio/TODO: Update TODO Original commit message from CVS: * gst-libs/gst/audio/TODO: Update TODO * gst-libs/gst/audio/gstbaseaudiosink.c: (gst_base_audio_sink_get_offset): When trying to play samples ASAP and we don't have a previous sample, try to play at position 0 instead of an invalid position. --- ChangeLog | 11 +++++++++++ gst-libs/gst/audio/TODO | 2 ++ gst-libs/gst/audio/gstbaseaudiosink.c | 3 +++ 3 files changed, 16 insertions(+) diff --git a/ChangeLog b/ChangeLog index c5fb58ab3a..a637bd2a9e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +2006-02-17 Wim Taymans + + * gst-libs/gst/audio/TODO: + Update TODO + + * gst-libs/gst/audio/gstbaseaudiosink.c: + (gst_base_audio_sink_get_offset): + When trying to play samples ASAP and we don't have a + previous sample, try to play at position 0 instead of + an invalid position. + 2006-02-17 Wim Taymans * ext/alsa/gstalsasink.c: (gst_alsasink_open), diff --git a/gst-libs/gst/audio/TODO b/gst-libs/gst/audio/TODO index 89fdeb6969..887f340b44 100644 --- a/gst-libs/gst/audio/TODO +++ b/gst-libs/gst/audio/TODO @@ -11,3 +11,5 @@ TODO - more accurate master/slave calibration handling - faster audio cutoff when going to PAUSED - resubmit samples from ringbuffer when doing PAUSED->PLAYING again + - the ringbuffer should have a state where it is filling up the + buffer before going to playing. diff --git a/gst-libs/gst/audio/gstbaseaudiosink.c b/gst-libs/gst/audio/gstbaseaudiosink.c index 110b3ae176..58ff3e3cca 100644 --- a/gst-libs/gst/audio/gstbaseaudiosink.c +++ b/gst-libs/gst/audio/gstbaseaudiosink.c @@ -434,6 +434,9 @@ gst_base_audio_sink_get_offset (GstBaseAudioSink * sink) /* assume we can append to the previous sample */ sample = sink->next_sample; + /* no previous sample, try to insert at position 0 */ + if (sample == -1) + sample = 0; sps = sink->ringbuffer->samples_per_seg;