From 44358f1eaf9aa52155900d618e2653e1cac55d6c Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Wed, 10 Mar 2021 16:22:14 +0100 Subject: [PATCH] audioaggregator: fix input buffer when converting This code path is meant to convert the current buffer to the new format on update. It was using priv->input_buffer as input which is either priv->buffer or a converted version of it. Use priv->buffer instead as priv->input_buffer may no longer be a valid reference. Part-of: --- gst-libs/gst/audio/gstaudioaggregator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst-libs/gst/audio/gstaudioaggregator.c b/gst-libs/gst/audio/gstaudioaggregator.c index 85dbd2ae61..d8da5db2ed 100644 --- a/gst-libs/gst/audio/gstaudioaggregator.c +++ b/gst-libs/gst/audio/gstaudioaggregator.c @@ -1071,7 +1071,7 @@ gst_audio_aggregator_update_converters (GstAudioAggregator * aagg, if (aaggpad->priv->buffer) { GstBuffer *new_converted_buffer = gst_audio_aggregator_convert_buffer (aagg, GST_PAD (aaggpad), - old_info, new_info, aaggpad->priv->input_buffer); + old_info, new_info, aaggpad->priv->buffer); gst_buffer_replace (&aaggpad->priv->buffer, new_converted_buffer); gst_buffer_unref (new_converted_buffer); }