From 44322b1dfcf50cbb205a6e6540043f59db9d3d2a Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Fri, 12 Jul 2019 20:39:45 -0400 Subject: [PATCH] vc1parse: Avoid division by zero assertion A framerate of 0/1 is valid, but we cannot calculate the frame duration in this context. Simply protect against this case. Related to #660 --- gst/videoparsers/gstvc1parse.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gst/videoparsers/gstvc1parse.c b/gst/videoparsers/gstvc1parse.c index d80f9bba2c..a207dda9f6 100644 --- a/gst/videoparsers/gstvc1parse.c +++ b/gst/videoparsers/gstvc1parse.c @@ -891,8 +891,9 @@ gst_vc1_parse_update_caps (GstVC1Parse * vc1parse) gst_caps_set_simple (caps, "framerate", GST_TYPE_FRACTION, vc1parse->fps_n, vc1parse->fps_d, NULL); - vc1parse->frame_duration = gst_util_uint64_scale (GST_SECOND, - vc1parse->fps_d, vc1parse->fps_n); + if (vc1parse->fps_n > 0) + vc1parse->frame_duration = gst_util_uint64_scale (GST_SECOND, + vc1parse->fps_d, vc1parse->fps_n); } if (vc1parse->par_n != 0 && vc1parse->par_d != 0)