From 43bf898f2d078caba15419e9ba56412565e28c48 Mon Sep 17 00:00:00 2001
From: Edward Hervey <edward@centricular.com>
Date: Sat, 29 Jun 2024 09:52:42 +0200
Subject: [PATCH] nlecomposition: Don't leak atomic rc box

* gst_structure_get => increases ref
* query_ancestors_position: There are two refs.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7116>
---
 .../gst-editing-services/plugins/nle/nlecomposition.c       | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/subprojects/gst-editing-services/plugins/nle/nlecomposition.c b/subprojects/gst-editing-services/plugins/nle/nlecomposition.c
index eb6f7688b8..4805a70578 100644
--- a/subprojects/gst-editing-services/plugins/nle/nlecomposition.c
+++ b/subprojects/gst-editing-services/plugins/nle/nlecomposition.c
@@ -1105,6 +1105,8 @@ nle_composition_handle_message (GstBin * bin, GstMessage * message)
       }
       g_mutex_unlock (&q->lock);
 
+      g_atomic_rc_box_release (q);
+
       /* We recursed up already */
       return;
     }
@@ -1906,6 +1908,10 @@ query_ancestors_position (NleComposition * comp)
     res = get_current_position (comp);
   }
   g_mutex_unlock (&q->lock);
+
+  /* Double release. One for the creation. One for the extra we gave to the
+   * structure */
+  g_atomic_rc_box_release (q);
   g_atomic_rc_box_release (q);
 
   return res;