From 4151e8e05242cc17c6f91d66c3c1f4fe02eea580 Mon Sep 17 00:00:00 2001
From: Seungha Yang <seungha@centricular.com>
Date: Mon, 28 Dec 2020 04:33:11 +0900
Subject: [PATCH] d3d11shader: Fix ID3DBlob object leak

Even if HLSL compiler was able to compile our shader code, D3DCompile()
might return ID3DBlob object for compile warnings and the object
should be released.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1914>
---
 sys/d3d11/gstd3d11shader.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sys/d3d11/gstd3d11shader.c b/sys/d3d11/gstd3d11shader.c
index 905ea87840..7c2dd7730a 100644
--- a/sys/d3d11/gstd3d11shader.c
+++ b/sys/d3d11/gstd3d11shader.c
@@ -136,6 +136,13 @@ compile_shader (GstD3D11Device * device, const gchar * shader_source,
     return NULL;
   }
 
+  if (error) {
+    const gchar *err = ID3D10Blob_GetBufferPointer (error);
+
+    GST_WARNING ("HLSL compiler warnings:\n%s", GST_STR_NULL (err));
+    ID3D10Blob_Release (error);
+  }
+
   return ret;
 }