rtsp-server: Add more warning flags

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
This commit is contained in:
Edward Hervey 2025-01-10 08:57:51 +01:00 committed by GStreamer Marge Bot
parent 959d58fd98
commit 4113101145
2 changed files with 18 additions and 11 deletions

View File

@ -2341,6 +2341,7 @@ gst_rtsp_client_sink_loop_rx (GstRTSPClientSink * sink)
break; break;
case GST_RTSP_ENET: case GST_RTSP_ENET:
GST_DEBUG_OBJECT (sink, "An ethernet problem occured."); GST_DEBUG_OBJECT (sink, "An ethernet problem occured.");
/* FALLTHROUGH */
default: default:
GST_ELEMENT_WARNING (sink, RESOURCE, READ, (NULL), GST_ELEMENT_WARNING (sink, RESOURCE, READ, (NULL),
("Unhandled return value %d.", res)); ("Unhandled return value %d.", res));
@ -2988,7 +2989,8 @@ receive_error:
FALSE)) == 0) FALSE)) == 0)
goto again; goto again;
} }
/* only try once after reconnect, then fallthrough and error out */ /* only try once after reconnect, else carry on and error out */
/* FALLTHROUGH */
default: default:
{ {
gchar *str = gst_rtsp_strresult (res); gchar *str = gst_rtsp_strresult (res);
@ -4912,8 +4914,8 @@ gst_rtsp_client_sink_handle_message (GstBin * bin, GstMessage * message)
gst_element_state_get_name (newstate), gst_element_state_get_name (newstate),
gst_element_state_get_name (pending), rtsp_client_sink->prerolled); gst_element_state_get_name (pending), rtsp_client_sink->prerolled);
} }
/* fallthrough */
} }
/* FALLTHROUGH */
default: default:
{ {
GST_BIN_CLASS (parent_class)->handle_message (bin, message); GST_BIN_CLASS (parent_class)->handle_message (bin, message);

View File

@ -109,23 +109,28 @@ cdata.set_quoted('GST_PACKAGE_ORIGIN', get_option('package-origin'))
rtspserver_args = ['-DHAVE_CONFIG_H'] rtspserver_args = ['-DHAVE_CONFIG_H']
# NOTE: Keep entries alphabetically sorted
warning_flags = [ warning_flags = [
'-Wmissing-declarations', '-Waddress',
'-Wmissing-prototypes', '-Waggregate-return',
'-Wredundant-decls',
'-Wundef',
'-Wwrite-strings',
'-Wformat', '-Wformat',
'-Wformat-nonliteral', '-Wformat-nonliteral',
'-Wformat-security', '-Wformat-security',
'-Wold-style-definition', '-Wimplicit-fallthrough=3',
'-Waggregate-return',
'-Winit-self', '-Winit-self',
'-Wmissing-declarations',
'-Wmissing-include-dirs', '-Wmissing-include-dirs',
'-Waddress', '-Wmissing-parameter-type',
'-Wmissing-prototypes',
'-Wno-multichar', '-Wno-multichar',
'-Wvla', '-Wold-style-definition',
'-Wpointer-arith', '-Wpointer-arith',
'-Wredundant-decls',
'-Wshift-negative-value',
'-Wtype-limits',
'-Wundef',
'-Wvla',
'-Wwrite-strings',
] ]
foreach extra_arg : warning_flags foreach extra_arg : warning_flags